Render account sheet and detail modal in-tree for edge-to-edge#13
Merged
Conversation
Top-right avatar opens a bottom sheet with the signed-in email and a single Log out action. Drops the map overlays' bottom-bar clearance now that nothing sits there. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
React Native's Modal renders in a separate window whose statusBarTranslucent/navigationBarTranslucent props don't reliably draw behind the system bars on RN 0.85 + Android 15. That left the account scrim not covering the status bar and the sheet stopping above the nav buttons, and the detail modal's header/footer not matching the edge-to-edge map. Replace both Modals with in-tree absolute overlays so they share the map's edge-to-edge window and extend behind the status and navigation bars. Preserve the slide animation (Animated) and hardware-back handling the Modal previously provided. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
# Conflicts: # App.tsx
Both the account menu and element detail screen reimplemented the same workaround for RN Modal's separate-window/edge-to-edge bug (in-tree absolute mount, slide animation, hardware-back handling, pointer-event gating). Consolidate that into a single Sheet primitive with a bottom and fullscreen variant so the edge-to-edge knowledge lives in one place and future sheets don't reintroduce the bug. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modalwith in-tree absolute overlays for both the account sheet (App.tsx) and the element detail modal (ElementDetailModal.tsx).Modalrenders in a separate window whosestatusBarTranslucent/navigationBarTranslucentprops don't reliably draw behind the system bars. This left the account scrim not covering the status bar, the sheet stopping above the nav buttons, and the detail modal's header/footer not matching the edge-to-edge map.Animated) and hardware-back handling thatModalpreviously provided; safe-area insets still pad content clear of the bars.Test plan
bunx tsc --noEmit,bun run lint,bun run testall pass.